-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preventing some code not compiling under UWP in Release mode to be ge… #27
base: master
Are you sure you want to change the base?
Conversation
This problem keeps me from completing the Xamarin.Forms Android/iOS/UWP Custom Renderer for Veldrid I am about to release. |
I would really prefer not to make changes to this library because of what is effectively a compiler bug on one platform. I filed dotnet/runtime#35171 to see if there's a fix or workaround available. If not, then we can try and see what our options are. |
I have built a Vk.2.0.0 nuget based on a Vk.dll produced by the modified generator and explicitly referred to it in the UWP test application, along with the Veldrid.View nuget providing the Xamarin.Forms views and it did mask the 'real' Vk package mentioned by Veldrid : it works :-)! |
I have pushed a new commit:
|
@PhilippeMonteil Can you try out this branch and see if it fixes the issue? https://github.com/mellinoe/vk/tree/calli_rewrite_array_parameters |
I have tried to:
1>------ Rebuild All started: Project: App1, Configuration: Release x86 ------ |
I have made more tests: clearing my Nuget cache, incrementing the version of the Vk nuget generated from your branch and it works fine: I have been able to produce a new Veldrid.View nuget and to use it to build a UWP test application in release mode: excellent news, thanks a lot! |
…nerated.
Some methods including array parameters like 'VkComputePipelineCreateInfo[] pCreateInfos':
`public static unsafe VkResult vkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint createInfoCount, VkComputePipelineCreateInfo[] pCreateInfos, VkAllocationCallbacks* pAllocator, out VkPipeline pPipelines)
do not compile under UWP in Release mode. The generator has been modified to not generate them anymore. `